Messages in this thread | | | Date | Thu, 25 Aug 2022 21:40:03 -0500 | From | Bjorn Andersson <> | Subject | Re: [PATCH v2 1/2] clk: qcom: gcc-sc7180: Keep the USB GDSC always on |
| |
On Thu, Aug 25, 2022 at 06:21:58PM -0700, Matthias Kaehlcke wrote: > When the GDSC is disabled during system suspend USB is broken on > sc7180 when the system resumes. Mark the GDSC as always on to > make sure USB still works after system suspend. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Rajendra, where you able to find some time to look into take the GDSC into retention state? Do you suggest that I merge these two patches for now?
Thanks, Bjorn
> --- > I'm not entirely sure that this is the correct solution. What makes > me doubt is that only msm8953 sets ALWAYS_ON for the USB GDSC. Is USB > broken after suspend on all the other QC platforms? > > Changes in v2: > - set the flags of the GDSC not of the GDSC power domain > - updated commit message > > drivers/clk/qcom/gcc-sc7180.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/gcc-sc7180.c b/drivers/clk/qcom/gcc-sc7180.c > index c2ea09945c47..c0d7509a782e 100644 > --- a/drivers/clk/qcom/gcc-sc7180.c > +++ b/drivers/clk/qcom/gcc-sc7180.c > @@ -2225,6 +2225,7 @@ static struct gdsc usb30_prim_gdsc = { > .name = "usb30_prim_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > + .flags = ALWAYS_ON, > }; > > static struct gdsc hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc = { > -- > 2.37.2.672.g94769d06f0-goog >
| |