lkml.org 
[lkml]   [2022]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Linux-cachefs] [PATCH v3] cachefiles: fix error return code in cachefiles_ondemand_copen()
From
Date


在 2022/8/25 21:58, Gao Xiang 写道:
> On Thu, Aug 25, 2022 at 04:36:20PM +0300, Dan Carpenter wrote:
>> I spent a long time looking at this as well... It's really inscrutable
>> code. It would be more readable if we just spelled things out in the
>> most pedantic way possible:
>>
>
> Yeah, the following code looks much better. Ke, would you mind
> sending a version like below instead?

OK, I will update it.
>
> Thanks,
> Gao Xiang
>
>> diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
>> index 1fee702d5529..7e1586bd5cf3 100644
>> --- a/fs/cachefiles/ondemand.c
>> +++ b/fs/cachefiles/ondemand.c
>> @@ -158,9 +158,13 @@ int cachefiles_ondemand_copen(struct cachefiles_cache *cache, char *args)
>>
>> /* fail OPEN request if daemon reports an error */
>> if (size < 0) {
>> - if (!IS_ERR_VALUE(size))
>> - size = -EINVAL;
>> - req->error = size;
>> + if (!IS_ERR_VALUE(size)) {
>> + req->error = -EINVAL;
>> + ret = -EINVAL;
>> + } else {
>> + req->error = size;
>> + ret = 0;
>> + }
>> goto out;
>> }
>>
>>
>> --
>> Linux-cachefs mailing list
>> Linux-cachefs@redhat.com
>> https://listman.redhat.com/mailman/listinfo/linux-cachefs
> .
>

\
 
 \ /
  Last update: 2022-08-26 03:12    [W:2.102 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site