Messages in this thread | | | Date | Thu, 25 Aug 2022 23:54:01 +0000 | Subject | [PATCH v6 0/2] PCI: dwc: Add support for 64-bit MSI target addresses | From | Will McVicker <> |
| |
Hi All,
I've update patch 2/2 to address Robin's suggestions. This includes:
* Dropping the while-loop for retrying with a 64-bit mask in favor of retrying within the error if-statement. * Using an int for the DMA mask instead of a bool and ternary operation.
Thanks again for the reviews and sorry for the extra revision today! Hopefully this is the last one :) If not, I'd be fine to submit patch 1/2 without 2/2 to avoid resending patch 1/2 for future revisions of patch 2/2 (unless I don't need to do that anyway).
Thanks, Will
Will McVicker (2): PCI: dwc: Drop dependency on ZONE_DMA32
v6: * Retrying DMA allocation with 64-bit mask within the error if-statement. * Use an int for the DMA mask instead of a bool and ternary operation.
v5: * Updated patch 2/2 to first try with a 32-bit DMA mask. On failure, retry with a 64-bit mask if supported.
v4: * Updated commit descriptions. * Renamed msi_64b -> msi_64bit. * Dropped msi_64bit ternary use. * Dropped export of dw_pcie_msi_capabilities.
v3: * Switched to a managed DMA allocation. * Simplified the DMA allocation cleanup. * Dropped msi_page from struct dw_pcie_rp. * Allocating a u64 instead of a full page.
v2: * Fixed build error caught by kernel test robot * Fixed error handling reported by Isaac Manjarres PCI: dwc: Add support for 64-bit MSI target address
.../pci/controller/dwc/pcie-designware-host.c | 43 +++++++++---------- drivers/pci/controller/dwc/pcie-designware.c | 8 ++++ drivers/pci/controller/dwc/pcie-designware.h | 2 +- 3 files changed, 30 insertions(+), 23 deletions(-)
base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 -- 2.37.2.672.g94769d06f0-goog
| |