lkml.org 
[lkml]   [2022]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] iio: adc: mcp320x: add triggered buffer support
On Wed, Aug 24, 2022 at 1:46 PM Vincent Whitchurch
<vincent.whitchurch@axis.com> wrote:
>
> From: Axel Jonsson <axel.jonsson@axis.com>
>
> Add support for triggered buffers. Just read the channels in a loop to
> keep things simple.

...

> #include <linux/module.h>
> #include <linux/mod_devicetable.h>
> #include <linux/iio/iio.h>
> +#include <linux/interrupt.h>

Ordering?

But honestly, I prefer the linux/iio/* to be split in a separate group...

> +#include <linux/iio/buffer.h>
> +#include <linux/iio/triggered_buffer.h>
> +#include <linux/iio/trigger_consumer.h>
> #include <linux/regulator/consumer.h>
>

...and be put here.

...

> + device_index = spi_get_device_id(adc->spi)->driver_data;

Hmm... Wondering if this can be derived from channel number or alike.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-08-25 22:07    [W:0.105 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site