Messages in this thread | | | Date | Thu, 25 Aug 2022 16:31:42 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH RFC v1 2/3] perf: Add perf_event_attr::config3 |
| |
Em Thu, Aug 25, 2022 at 01:08:01PM -0500, Rob Herring escreveu: > Arm SPEv1.2 adds another 64-bits of event filtering control. As the > existing perf_event_attr::configN fields are all used up for SPE PMU, an > additional field is needed. Add a new 'config3' field.
Try not to have tools/ and kernel code in the same patch, else you'll burden kernel developers into testing tools/, which so far has been refrained.
First you get the kernel bits in, then tooling.
Locally of course you test it together.
- Arnaldo
> Signed-off-by: Rob Herring <robh@kernel.org> > > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index 03b370062741..b53f9b958235 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -333,6 +333,7 @@ enum perf_event_read_format { > #define PERF_ATTR_SIZE_VER5 112 /* add: aux_watermark */ > #define PERF_ATTR_SIZE_VER6 120 /* add: aux_sample_size */ > #define PERF_ATTR_SIZE_VER7 128 /* add: sig_data */ > +#define PERF_ATTR_SIZE_VER8 136 /* add: config3 */ > > /* > * Hardware event_id to monitor via a performance monitoring event: > @@ -474,6 +475,8 @@ struct perf_event_attr { > * truncated accordingly on 32 bit architectures. > */ > __u64 sig_data; > + > + __u64 config3; /* extension of config2 */ > }; > > /* > diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h > index 581ed4bdc062..7fad17853310 100644 > --- a/tools/include/uapi/linux/perf_event.h > +++ b/tools/include/uapi/linux/perf_event.h > @@ -333,6 +333,7 @@ enum perf_event_read_format { > #define PERF_ATTR_SIZE_VER5 112 /* add: aux_watermark */ > #define PERF_ATTR_SIZE_VER6 120 /* add: aux_sample_size */ > #define PERF_ATTR_SIZE_VER7 128 /* add: sig_data */ > +#define PERF_ATTR_SIZE_VER8 136 /* add: config3 */ > > /* > * Hardware event_id to monitor via a performance monitoring event: > @@ -474,6 +475,8 @@ struct perf_event_attr { > * truncated accordingly on 32 bit architectures. > */ > __u64 sig_data; > + > + __u64 config3; /* extension of config2 */ > }; > > /* > > -- > b4 0.10.0-dev
--
- Arnaldo
| |