Messages in this thread | | | Date | Thu, 25 Aug 2022 20:47:28 +0200 | From | Oleksij Rempel <> | Subject | Re: [PATCH net-next v2 6/7] ethtool: add interface to interact with Ethernet Power Equipment |
| |
On Thu, Aug 25, 2022 at 11:10:19AM -0700, Jakub Kicinski wrote: > On Thu, 25 Aug 2022 15:02:10 +0200 Oleksij Rempel wrote: > > +enum ethtool_podl_pse_admin_state { > > + ETHTOOL_PODL_PSE_ADMIN_STATE_UNKNOWN = 1, > > Why define UNKNOWN.. as 1? No real objection here, just in my head > somehow UNKNOWN = 0 or just start from 1.
I need to keep difference between not supported functionality and supported but unknown.
> > + ETHTOOL_PODL_PSE_ADMIN_STATE_DISABLED, > > + ETHTOOL_PODL_PSE_ADMIN_STATE_ENABLED, > > + > > + /* add new constants above here */ > > + ETHTOOL_PODL_PSE_ADMIN_STATE_COUNT > > Why define count for a value enum like this? For attrs we define it > because it's used to size tables, don't think anyone will size tables > based on states.
ok, i'll remove it.
> There's a bunch of kdoc warnings in the patches as well.
ok.
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |