Messages in this thread | | | Subject | Re: [PATCH v2 3/4] Revert "PM: domains: Delete usage of driver_deferred_probe_check_state()" | From | Martin Kepplinger <> | Date | Thu, 25 Aug 2022 08:57:58 +0200 |
| |
Am Freitag, dem 19.08.2022 um 15:16 -0700 schrieb Saravana Kannan: > This reverts commit 5a46079a96451cfb15e4f5f01f73f7ba24ef851a. > > Quite a few issues have been reported [1][2][3][4][5][6] on the > original > commit. While about half of them have been fixed, I'll need to fix > the rest > before driver_deferred_probe_check_state() can be deleted. So, revert > the > deletion for now. > > [1] - > https://lore.kernel.org/all/DU0PR04MB941735271F45C716342D0410886B9@DU0PR04MB9417.eurprd04.prod.outlook.com/ > [2] - https://lore.kernel.org/all/CM6REZS9Z8AC.2KCR9N3EFLNQR@otso/ > [3] - > https://lore.kernel.org/all/CAD=FV=XYVwaXZxqUKAuM5c7NiVjFz5C6m6gAHSJ7rBXBF94_Tg@mail.gmail.com/ > [4] - https://lore.kernel.org/all/Yvpd2pwUJGp7R+YE@euler/ > [5] - > https://lore.kernel.org/lkml/20220601070707.3946847-2-saravanak@google.com/ > [6] - > https://lore.kernel.org/all/CA+G9fYt_cc5SiNv1Vbse=HYY_+uc+9OYPZuJ-x59bROSaLN6fw@mail.gmail.com/ > > Fixes: 5a46079a9645 ("PM: domains: Delete usage of > driver_deferred_probe_check_state()") > Reported-by: Peng Fan <peng.fan@nxp.com> > Reported-by: Luca Weiss <luca.weiss@fairphone.com> > Reported-by: Doug Anderson <dianders@chromium.org> > Reported-by: Colin Foster <colin.foster@in-advantage.com> > Reported-by: Tony Lindgren <tony@atomide.com> > Reported-by: Alexander Stein <alexander.stein@ew.tq-group.com> > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Reviewed-by: Tony Lindgren <tony@atomide.com> > Tested-by: Tony Lindgren <tony@atomide.com> > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > drivers/base/power/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/power/domain.c > b/drivers/base/power/domain.c > index 5a2e0232862e..55a10e6d4e2a 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2733,7 +2733,7 @@ static int __genpd_dev_pm_attach(struct device > *dev, struct device *base_dev, > mutex_unlock(&gpd_list_lock); > dev_dbg(dev, "%s() failed to find PM domain: %ld\n", > __func__, PTR_ERR(pd)); > - return -ENODEV; > + return driver_deferred_probe_check_state(base_dev); > } > > dev_dbg(dev, "adding to PM domain %s\n", pd->name);
Fixes imx8mq where ENODEV results in: [ 1.048019] imx8m-blk-ctrl 38320000.blk-ctrl: error -ENODEV: failed to attach power domain "bus"
Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm>
thanks for fixing this,
martin
| |