lkml.org 
[lkml]   [2022]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH v2 1/2] scsi: ufs: Add Multi-Circular Queue support
From
On 8/25/2022 11:04 AM, Bart Van Assche wrote:
> On 8/24/22 18:42, Asutosh Das (asd) wrote:
>> On 8/18/2022 7:41 PM, Bart Van Assche wrote:
>>> On 8/11/22 03:33, Can Guo wrote:
>>>> +static inline void ufshcd_mcq_process_event(struct ufs_hba *hba,
>>>> +                        struct ufs_hw_queue *hwq)
>>>> +{
>>>> +    struct cq_entry *cqe = ufshcd_mcq_cur_cqe(hwq);
>>>> +    int tag;
>>>> +
>>>> +    tag = ufshcd_mcq_get_tag(hba, hwq, cqe);
>>>> +    ufshcd_compl_one_task(hba, tag, cqe);
>>>> +}
>>>
>>> Consider changing "process_event" into "process_cqe". Consider
>>> renaming ufshcd_compl_one_task() into ufshcd_compl_one_cqe().
>>>
>> The preparatory patch that would precede this change would define
>> ufshcd_compl_one_task() in ufshcd.c. Since this function would be
>> invoked both from Single Doorbell mode and MCQ mode,
>> ufshcd_compl_one_task() sounds more relevant. What say?
>
> The name "task" is confusing since in SCSI standard documents it refers
> to "task management" while ufshcd_compl_one_task() is not related to
> SCSI task management at all. So I would appreciate it if another name is
> chosen than ufshcd_compl_one_task().
>
Ok, makes sense. Will change the name in the next version.

Thanks,
-asd

\
 
 \ /
  Last update: 2022-08-25 20:09    [W:0.058 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site