Messages in this thread | | | From | Mateusz Kwiatkowski <> | Date | Wed, 24 Aug 2022 19:08:26 +0200 | Subject | Re: [PATCH v1 34/35] drm/modes: Introduce the tv_mode property as a command-line option |
| |
Hi Maxime & Noralf,
W dniu 24.08.2022 o 17:45, Maxime Ripard pisze: > Hi Noralf, > > On Sat, Aug 20, 2022 at 10:18:47PM +0200, Noralf Trønnes wrote: >> Den 29.07.2022 18.35, skrev Maxime Ripard: >>> Our new tv mode option allows to specify the TV mode from a property. >>> However, it can still be useful, for example to avoid any boot time >>> artifact, to set that property directly from the kernel command line. >>> >>> Let's add some code to allow it, and some unit tests to exercise that code. >>> >>> Signed-off-by: Maxime Ripard <maxime@cerno.tech> >>> >> >> In the subject it says "tv_mode property", but the property is called >> "tv norm", so the option should be tv_norm? > > Yeah... I don't know. mode is taken but it's obviously the best name. So > I went with norm to avoid the (internal) conflict but I left mode for > the user facing property. > > I'm not sure what's best here, or maybe we can pick another name entirely?
I think "standard" and "system" are also fairly common names for this property.
I once had an old multi-standard Sharp CRT TV that allowed manually selecting the expected color encoding (PAL/SECAM/NTSC/NTSC-443), and the relevant button on the remote was labeled "SYSTEM".
V4L2 calls this "standard", see include/uapi/linux/videodev2.h, compare with v4l2_std_id, V4L2_STD_* etc.
BTW, maybe reusing those V4L2 constants, or aligning the numerical values, would make some sense?
> > Maxime
Best regards, Mateusz Kwiatkowski
| |