lkml.org 
[lkml]   [2022]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] scsi: ufs: ufsfbo: Introduce File Based Optimization feature
From
On 8/24/22 01:46, Jiaming Li wrote:
> +#include "../../../block/blk.h"

Without having taken a look at the rest of this patch, including a block
driver private header file in the UFS driver is unacceptable.

> +#define FBO_INFO_MSG(fbo, msg, args...) do { \
> + if (fbo->fbo_debug) \
> + pr_info("[info]%s:%d:" msg "\n", __func__, __LINE__, ##args); \
> + } while (0)

Please use pr_debug() instead.

> +#define FBO_ERR_MSG(msg, args...) \
> + pr_err("[err]%s:%d:" msg "\n", __func__, __LINE__, ##args)

Please use pr_err() directly and remove the function name and line
numbers from error messages.

> +#define FBO_WARN_MSG(msg, args...) \
> + pr_warn("[warn]%s:%d:" msg "\n", __func__, __LINE__, ##args)

Please use pr_warn directly and remove function name and line numbers
from warning messages.

Thanks,

Bart.

\
 
 \ /
  Last update: 2022-08-24 18:37    [W:0.117 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site