lkml.org 
[lkml]   [2022]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support
    Date


    > -----Original Message-----
    > From: 'Guanjun' <guanjun@linux.alibaba.com>
    > Sent: Wednesday, August 24, 2022 4:50 AM
    > Subject: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support
    >
    ...

    > +static struct skcipher_alg ycc_skciphers[] = {
    > + {
    > + .base = {
    > + .cra_name = "cbc(aes)",
    > + .cra_driver_name = "ycc_cbc(aes)",

    In comparison, the aead driver puts the hardware driver name as a suffix,
    not a prefix, and uses dashes rather than underscores and parenthesis:
    > + .cra_name = "gcm(aes)",
    > + .cra_driver_name = "gcm-aes-ycc",

    and the pk driver uses a prefix with a dash:
    > + .cra_name = "rsa",
    > + .cra_driver_name = "ycc-rsa",

    Although the existing drivers are wildly inconsistent, it would be nice
    if this driver was at least consistent with itself. Suffixes with dashes
    seem to be the most popular, so consider these formats:
    cbc-aes-ycc
    gcm-aes-ycc
    rsa-ycc


    \
     
     \ /
      Last update: 2022-08-24 18:25    [W:4.548 / U:0.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site