Messages in this thread | | | Date | Wed, 24 Aug 2022 17:30:51 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver |
| |
On Wed, Aug 24, 2022 at 08:06:59AM -0400, Charles Mirabile wrote: > On Tue, Aug 23, 2022 at 5:30 PM Stefan Wahren <stefan.wahren@i2se.com> wrote: > > > drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver > > We don't have an Ack for this display driver. Maybe we should ask Maxime > > Ripard and Noralf Trønnes especially Pavel Machek had concerns about the > > right subsystem? > > I just looked back at the comments from Pavel on v9. I had meant to > reply to him, and I actually drafted something but it got lost in the > shuffle and I never sent it (also my bad). > > The driver is an fbdev in the raspberry pi tree, and that is where we > started when upstreaming, but right from the outset we were told that > it couldn't be an fbdev since that subsystem is being deprecated > the replacement is the DRM subsystem
Indeed
> but (as Matthias Brugger suggests) that is probably overkill for an > 8x8 display. Does that settle the subsystem question?
If you were aiming for an fbdev driver, a KMS driver these days would be notably simpler.
We've added simpler and simpler devices, such as the SSD1306 recently, so I can't see anything wrong with using KMS either.
Maxime [unhandled content-type:application/pgp-signature] | |