Messages in this thread | | | Date | Wed, 24 Aug 2022 17:22:37 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 1/6] sysfs: do not create empty directories if no attributes are present |
| |
On Wed, Aug 24, 2022 at 05:17:44PM +0200, Pierre-Louis Bossart wrote: > > > On 8/24/22 15:59, Greg Kroah-Hartman wrote: > > When creating an attribute group, if it is named a subdirectory is > > created and the sysfs files are placed into that subdirectory. If no > > files are created, normally the directory would still be present, but it > > would be empty. Clean this up by removing the directory if no files > > were successfully created in the group at all. > > > > Cc: Vinod Koul <vkoul@kernel.org> > > Cc: Bard Liao <yung-chuan.liao@linux.intel.com> > > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > Cc: Sanyog Kale <sanyog.r.kale@intel.com> > > Cc: alsa-devel@alsa-project.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > v2: new patch > > > > Note, totally untested! The following soundwire patches will need this, > > if a soundwire developer could test this out, it would be most > > apreciated. > > Not able to see the kernel boot with this first patch. The device is > stuck with the cursor not even blinking. It seems our CI test devices > are also stuck. > > This is completely beyond my comfort zone but I can run more tests to > root cause this.
Ick, ok, so much for sending out untested patches :(
I'll test and debug this tomorrow and resend a correct version, thanks for helping out here, sorry it didn't work.
greg k-h
| |