Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH v4 4/4] dt-bindings: riscv: isa string bonus content | Date | Wed, 24 Aug 2022 08:26:57 -0500 |
| |
On Tue, 23 Aug 2022 19:33:20 +0100, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > **NOT FOR CONSIDERATION** > > I figured, sure why not add the strings for version number validation, > just in case we need them in the future. The commented out string is > considered by dt-schema to be "not a regex", but regex101 thinks it > is... Maybe dt-schema does not support named match groups, but they > are the only way that I could trivially find to make this somewhat > manageable. Either way, it is permissive so it allows combinations > of "M", "MpM" & no number. > > Not-signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > Documentation/devicetree/bindings/riscv/cpus.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors: ./Documentation/devicetree/bindings/riscv/cpus.yaml:87:111: [warning] line too long (297 > 110 characters) (line-length)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |