Messages in this thread | | | Date | Wed, 24 Aug 2022 14:33:38 +0200 | From | Andrew Lunn <> | Subject | Re: [EXT] Re: [PATCH] octeontx2-pf: Add egress PFC support |
| |
> >> - schq = hw->txschq_list[lvl][0]; > >> +#ifdef CONFIG_DCB > >> + if (txschq_for_pfc) > >> + schq = pfvf->pfc_schq_list[lvl][prio]; > >> + else > >> +#endif > > > >Please could you try to remove as many of these #ifdef CONFIG_DCB as > >possible. It makes build testing less efficient at finding build > >problems. Can you do: > > > >> + if (IS_ENABLED(CONFIG_DCB) && txschq_for_pfc) > >> + schq = pfvf->pfc_schq_list[lvl][prio]; > > > [Suman] I will restructured the code. But we cannot use pfvf->pfc_schq_list outside #ifdef CONFIG_DCB as these are defined under the > macro in otx2_common.h
So maybe add a getter and setter in otx2_common.h, which returns -EOPNOTSUPP or similar when CONFIG_DCB is disabled?
Andrew
| |