Messages in this thread Patch in this message | | | From | Manivannan Sadhasivam <> | Subject | [PATCH v2 4/5] misc: pci_endpoint_test: Remove unnecessary WARN_ON | Date | Wed, 24 Aug 2022 18:00:09 +0530 |
| |
If unable to map test_reg_bar, then probe will fail with a dedicated error message. So there is no real need of WARN_ON here.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- drivers/misc/pci_endpoint_test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index a7d8ae9730f6..5e4d4691a160 100644 --- a/drivers/misc/pci_endpoint_test.c +++ b/drivers/misc/pci_endpoint_test.c @@ -810,10 +810,8 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { if (pci_resource_flags(pdev, bar) & IORESOURCE_MEM) { base = pci_ioremap_bar(pdev, bar); - if (!base) { + if (!base) dev_err(dev, "Failed to read BAR%d\n", bar); - WARN_ON(bar == test_reg_bar); - } test->bar[bar] = base; } } -- 2.25.1
| |