lkml.org 
[lkml]   [2022]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v10 0/6] Raspberry Pi Sense HAT driver
On Wed, Aug 24, 2022 at 7:28 AM Matthias Brugger <mbrugger@suse.com> wrote:
>
>
>
> On 23/08/2022 19:41, Charles Mirabile wrote:
> > This patch series adds a set of drivers for operating the Sense HAT
> > peripheral device. This board is an add on for the Raspberry Pi that is
> > designed to connect using the GPIO connector and communicate via I2C.
> >
> > It features:
> > - a joystick
> > - an 8x8 RGB LED matrix display
> > - a whole bunch of environmental sensors with their own drivers
> > (those are already in upstream Linux)
> >
> > This is a refactor of the work of Serge Schneider, the author of a
> > version of this driver that is currently in the Raspberry Pi downstream
> > kernel. We modified his code to make it suitable for upstream Linux.
> >
> > A couple of tests are available for the driver in the test folder in
> > this repo: https://github.com/underground-software/sensehat.git
> > - sensehat_joystick_test logs the input events from the
> > joystick to the console
> > - sensehat_display_test displays various solid colors on
> > the LED panel.
> > - full_sensehat_test displays a single lit cell that can be
> > moved with the joystick. Pressing the joystick ends the
> > program.
> >
> > For more information about the Sense HAT, visit:
> > https://www.raspberrypi.org/products/sense-hat/
> >
> > Changes since v9:
> > - The driver for the sensehat joystick was accepted upstream so
> > it is no longer included in this patchset.
> > - Some of the people involved in the development of earlier
> > versions of these patches are no longer involved in the project
> > so they have been removed from the list of maintainers and the
> > patches.
>
> I'd would expect the patches to honor their involvement in the past, but if they
> are fine from being dropped, I will not object...
Since I am sending a v11 I will try to get in touch with them and see
if they want
to be involved and find proper emails (they no longer work at Red Hat).
I will also look into how much / to which parts of the code they
contributed and see
where it is appropriate to include them if they do want to be
included. I should have
done this before sending v10, but I didn't have the proper emails and
wasn't sure
about the correct etiquette.
>
> Regards,
> Matthias
>
> > - The code is completely unchanged and so based on the discussions
> > from version 9 of the patches, it should be ready to be merged.
> >
> > My appologies for the long delay between v9 and v10 especially given the
> > fact that there are no changes to the code. We appreciate the maintainers'
> > patience and guidance throughout all 10 versions of this sensehat patchset,
> > and we are excited for this driver to hopefully be fully accepted.
> >
> > Best - Charlie
> >
> > Co-developed-by: Joel Slebodnick <jslebodn@redhat.com>
> > Signed-off-by: Joel Slebodnick <jslebodn@redhat.com>
> > Co-developed-by: Joel Savitz <jsavitz@redhat.com>
> > Signed-off-by: Joel Savitz <jsavitz@redhat.com>
> > Signed-off-by: Charles Mirabile <cmirabil@redhat.com>
> >
> > Charles Mirabile (5):
> > drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c
> > drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver
> > dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema
> > MAINTAINERS: Add sensehat driver authors to MAINTAINERS
> > DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4
> >
> > .../raspberrypi,sensehat-display.yaml | 26 +++
> > .../input/raspberrypi,sensehat-joystick.yaml | 31 +++
> > .../bindings/mfd/raspberrypi,sensehat.yaml | 57 +++++
> > MAINTAINERS | 10 +
> > drivers/auxdisplay/Kconfig | 8 +
> > drivers/auxdisplay/Makefile | 1 +
> > drivers/auxdisplay/sensehat-display.c | 205 ++++++++++++++++++
> > drivers/mfd/simple-mfd-i2c.c | 1 +
> > sensehat.dtbs | 52 +++++
> > 9 files changed, 391 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml
> > create mode 100644 Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml
> > create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
> > create mode 100644 drivers/auxdisplay/sensehat-display.c
> > create mode 100644 sensehat.dtbs
> >
>

\
 
 \ /
  Last update: 2022-08-24 14:20    [W:0.172 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site