Messages in this thread | | | Date | Wed, 24 Aug 2022 10:44:01 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH] cxl: Replace HDM decoder granularity magic numbers |
| |
On Mon, 22 Aug 2022 10:17:03 -0700 Davidlohr Bueso <dave@stgolabs.net> wrote:
> On Mon, 22 Aug 2022, Adam Manzanares wrote: > > >When reviewing the CFMWS parsing code that deals with the HDM decoders, > >I noticed a couple of magic numbers. This commit replaces these magic numbers > >with constants defined by the CXL 2.0 specification. > > Please use 3.0 spec :) > > Actually the whole drivers/cxl/* could use updating the comments for 3.0.
Interesting point. What do we want to do on this? Most similar cases I've been involved on rely on referring to 'oldest' compatible spec. (this is true for ACPI stuff for example).
I don't care either way, but a policy on this will save us some time by ensuring we meet that policy before sending for review.
Jonathan
| |