lkml.org 
[lkml]   [2022]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] selftests: remove unused variable in close_range test
On Tue, Aug 23, 2022 at 10:48:11PM +0000, Andrew Delgadilo wrote:
> From: Andrew Delgadillo <adelg@google.com>
>
> commit 2c5db60e46ad ("tests: add close_range() tests") adds the
> close_range test under the core namespace. In its current form, the
> close_range test has an unused variable, namely, ret. For those building
> with -Werror,-Wall, this breaks the build.
>
> Without this patch:
> $ make -C tools/testing/selftests/ TARGETS=core V=1 CFLAGS="-Werror -Wall"
> > make: Entering directory '/.../kernel-src/tools/testing/selftests'
> > make[1]: Entering directory '/.../kernel-src/tools/testing/selftests/core'
> > gcc -Werror -Wall close_range_test.c -o /.../kernel-src/tools/testing/selftests/core/close_range_test
> > close_range_test.c: In function 'core_close_range':
> > close_range_test.c:55:16: error: unused variable 'ret' [-Werror=unused-variable]
> > 55 | int i, ret;
> > | ^~~
> > cc1: all warnings being treated as errors
> > make[1]: *** [../lib.mk:135: /.../kernel-src/tools/testing/selftests/core/close_range_test] Error 1
> > make[1]: Leaving directory '/.../kernel-src/tools/testing/selftests/core'
> > make: *** [Makefile:155: all] Error 2
> > make: Leaving directory '/.../kernel-src/tools/testing/selftests'
>
> With this patch:
> $ make -C tools/testing/selftests/ TARGETS=core V=1 CFLAGS="-Werror -Wall"
> > make: Entering directory '/.../kernel-src/tools/testing/selftests'
> > make[1]: Entering directory '/.../kernel-src/tools/testing/selftests/core'
> > gcc -Werror -Wall close_range_test.c -o /.../kernel-src/tools/testing/selftests/core/close_range_test
> > make[1]: Leaving directory '/.../kernel-src/tools/testing/selftests/core'
> > make: Leaving directory '/.../kernel-src/tools/testing/selftests'
>
> Fixes: 2c5db60e46ad ("tests: add close_range() tests")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andrew Delgadillo <adelg@google.com>
> ---

Thanks,
Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>

\
 
 \ /
  Last update: 2022-08-24 09:17    [W:0.028 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site