Messages in this thread | | | Subject | Re: [PATCH] kvm: x86: mmu: fix memoryleak in kvm_mmu_vendor_module_init() | From | Miaohe Lin <> | Date | Thu, 25 Aug 2022 09:43:25 +0800 |
| |
On 2022/8/24 23:44, Sean Christopherson wrote: > Nit for future patches, please use > > KVM: x86/mmu: > > for the scope.
Will take care of it.
> > On Tue, Aug 23, 2022, Miaohe Lin wrote: >> When register_shrinker() fails, we forgot to release the percpu counter >> kvm_total_used_mmu_pages leading to memoryleak. Fix this issue by calling >> percpu_counter_destroy() when register_shrinker() fails. >> >> Fixes: ab271bd4dfd5 ("x86: kvm: propagate register_shrinker return code") >> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> >> --- > > Reviewed-by: Sean Christopherson <seanjc@google.com>
Many thanks for your review.
Thanks, Miaohe Lin
| |