lkml.org 
[lkml]   [2022]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] selftests: KVM: Introduce vcpu_run_interruptable()
On Tue, Aug 02, 2022, Mingwei Zhang wrote:
> Introduce vcpu_run_interruptable() to allow selftests execute their own
> code when a vcpu is kicked out of KVM_RUN on receiving a POSIX signal.

But that's what __vcpu_run() is for. Clearing "immediate_exit" after KVM_RUN does
not scream "interruptible" to me.

There's only one user after this series, just clear vcpu->run->immediate_exit
manually in that test (a comment on _why_ it's cleared would be helpful).

> +int vcpu_run_interruptable(struct kvm_vcpu *vcpu)
> +{
> + int rc;
> +
> + rc = __vcpu_run(vcpu);
> +
> + vcpu->run->immediate_exit = 0;
> +
> + return rc;
> +}
> +
> int _vcpu_run(struct kvm_vcpu *vcpu)
> {
> int rc;
> --
> 2.37.1.455.g008518b4e5-goog
>

\
 
 \ /
  Last update: 2022-08-25 02:15    [W:0.145 / U:4.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site