lkml.org 
[lkml]   [2022]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 04/13] KVM: x86: emulator: update the emulation mode after rsm
On Wed, Aug 03, 2022, Maxim Levitsky wrote:

Please make the changelog standalone, even though it means restating the shortlog
in most cases. When viewing git commits, the shortlog+changelog are bundled
fairly close together, but when viewing patches in a mail client, e.g. when doing
initial review, the shortlog is in the subject which may be far away or even
completely hidden.

> This ensures that RIP will be correctly written back,
> because the RSM instruction can switch the CPU mode from
> 32 bit (or less) to 64 bit.

Wrap closer to ~75 chars.

>
> This fixes a guest crash in case the #SMI is received
> while the guest runs a code from an address > 32 bit.
>
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
> arch/x86/kvm/emulate.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index bc70caf403c2b4..5e91b26cc1d8aa 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -2666,6 +2666,11 @@ static int em_rsm(struct x86_emulate_ctxt *ctxt)
> if (ret != X86EMUL_CONTINUE)
> goto emulate_shutdown;
>
> +

Unnecessary newline.

> + ret = emulator_recalc_and_set_mode(ctxt);
> + if (ret != X86EMUL_CONTINUE)
> + goto emulate_shutdown;
> +
> /*
> * Note, the ctxt->ops callbacks are responsible for handling side
> * effects when writing MSRs and CRs, e.g. MMU context resets, CPUID
> --
> 2.26.3
>

\
 
 \ /
  Last update: 2022-08-24 23:51    [W:2.478 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site