lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 077/244] mlx5: do not use RT_TOS for IPv6 flowlabel
    Date
    From: Matthias May <matthias.may@westermo.com>

    commit bcb0da7fffee9464073998b267ce5543da2356d2 upstream.

    According to Guillaume Nault RT_TOS should never be used for IPv6.

    Quote:
    RT_TOS() is an old macro used to interprete IPv4 TOS as described in
    the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
    code, although, given the current state of the code, most of the
    existing calls have no consequence.

    But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
    field to be interpreted the RFC 1349 way. There's no historical
    compatibility to worry about.

    Fixes: ce99f6b97fcd ("net/mlx5e: Support SRIOV TC encapsulation offloads for IPv6 tunnels")
    Acked-by: Guillaume Nault <gnault@redhat.com>
    Signed-off-by: Matthias May <matthias.may@westermo.com>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c
    @@ -497,7 +497,7 @@ int mlx5e_tc_tun_create_header_ipv6(stru
    int err;

    attr.ttl = tun_key->ttl;
    - attr.fl.fl6.flowlabel = ip6_make_flowinfo(RT_TOS(tun_key->tos), tun_key->label);
    + attr.fl.fl6.flowlabel = ip6_make_flowinfo(tun_key->tos, tun_key->label);
    attr.fl.fl6.daddr = tun_key->u.ipv6.dst;
    attr.fl.fl6.saddr = tun_key->u.ipv6.src;

    @@ -611,7 +611,7 @@ int mlx5e_tc_tun_update_header_ipv6(stru

    attr.ttl = tun_key->ttl;

    - attr.fl.fl6.flowlabel = ip6_make_flowinfo(RT_TOS(tun_key->tos), tun_key->label);
    + attr.fl.fl6.flowlabel = ip6_make_flowinfo(tun_key->tos, tun_key->label);
    attr.fl.fl6.daddr = tun_key->u.ipv6.dst;
    attr.fl.fl6.saddr = tun_key->u.ipv6.src;


    \
     
     \ /
      Last update: 2022-08-23 11:56    [W:3.534 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site