lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 063/244] pinctrl: nomadik: Fix refcount leak in nmk_pinctrl_dt_subnode_to_map
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit 4b32e054335ea0ce50967f63a7bfd4db058b14b9 upstream.

    of_parse_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak."

    Fixes: c2f6d059abfc ("pinctrl: nomadik: refactor DT parser to take two paths")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220607111602.57355-1-linmq006@gmail.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
    +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
    @@ -1421,8 +1421,10 @@ static int nmk_pinctrl_dt_subnode_to_map

    has_config = nmk_pinctrl_dt_get_config(np, &configs);
    np_config = of_parse_phandle(np, "ste,config", 0);
    - if (np_config)
    + if (np_config) {
    has_config |= nmk_pinctrl_dt_get_config(np_config, &configs);
    + of_node_put(np_config);
    + }
    if (has_config) {
    const char *gpio_name;
    const char *pin;

    \
     
     \ /
      Last update: 2022-08-23 11:51    [W:4.132 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site