lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Split multiple assignments to individual lines.
On Mon, Aug 22, 2022 at 08:05:57PM +0200, Philipp Hortmann wrote:
> I personally prefer more this:
>
> > + sm750_dev->fbinfo[1] = NULL;
> > + sm750_dev->fbinfo[0] = NULL;
>
> That gives a better overview.
>

Same for everywhere. Literals are clear than variables.

Bad: foo = bar;
Good: foo = -1;

Avoid pointless indirection.

regards,
dan carpenter

\
 
 \ /
  Last update: 2022-08-23 11:47    [W:0.072 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site