lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 304/365] csky/kprobe: reclaim insn_slot on kprobe unregistration
    Date
    From: Liao Chang <liaochang1@huawei.com>

    [ Upstream commit a2310c74d418deca0f1d749c45f1f43162510f51 ]

    On kprobe registration kernel allocate one insn_slot for new kprobe,
    but it forget to reclaim the insn_slot on unregistration, leading to a
    potential leakage.

    Reported-by: Chen Guokai <chenguokai17@mails.ucas.ac.cn>
    Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
    Signed-off-by: Liao Chang <liaochang1@huawei.com>
    Signed-off-by: Guo Ren <guoren@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/csky/kernel/probes/kprobes.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/arch/csky/kernel/probes/kprobes.c b/arch/csky/kernel/probes/kprobes.c
    index 34ba684d5962..3c6e5c725d81 100644
    --- a/arch/csky/kernel/probes/kprobes.c
    +++ b/arch/csky/kernel/probes/kprobes.c
    @@ -124,6 +124,10 @@ void __kprobes arch_disarm_kprobe(struct kprobe *p)

    void __kprobes arch_remove_kprobe(struct kprobe *p)
    {
    + if (p->ainsn.api.insn) {
    + free_insn_slot(p->ainsn.api.insn, 0);
    + p->ainsn.api.insn = NULL;
    + }
    }

    static void __kprobes save_previous_kprobe(struct kprobe_ctlblk *kcb)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 11:47    [W:3.206 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site