lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 089/229] i2c: mux-gpmux: Add of_node_put() when breaking out of loop
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 6435319c34704994e19b0767f6a4e6f37439867b ]

    In i2c_mux_probe(), we should call of_node_put() when breaking out
    of for_each_child_of_node() which will automatically increase and
    decrease the refcount.

    Fixes: ac8498f0ce53 ("i2c: i2c-mux-gpmux: new driver")
    Signed-off-by: Liang He <windhl@126.com>
    Acked-by: Peter Rosin <peda@axentia.se>
    Signed-off-by: Wolfram Sang <wsa@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/i2c/muxes/i2c-mux-gpmux.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/i2c/muxes/i2c-mux-gpmux.c b/drivers/i2c/muxes/i2c-mux-gpmux.c
    index 92cf5f48afe6..5053f1675a29 100644
    --- a/drivers/i2c/muxes/i2c-mux-gpmux.c
    +++ b/drivers/i2c/muxes/i2c-mux-gpmux.c
    @@ -141,6 +141,7 @@ static int i2c_mux_probe(struct platform_device *pdev)
    return 0;

    err_children:
    + of_node_put(child);
    i2c_mux_del_adapters(muxc);
    err_parent:
    i2c_put_adapter(parent);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 11:45    [W:3.073 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site