lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 058/229] thermal/tools/tmon: Include pthread and time headers in tmon.h
    Date
    From: Markus Mayer <mmayer@broadcom.com>

    [ Upstream commit 0cf51bfe999524377fbb71becb583b4ca6d07cfc ]

    Include sys/time.h and pthread.h in tmon.h, so that types
    "pthread_mutex_t" and "struct timeval tv" are known when tmon.h
    references them.

    Without these headers, compiling tmon against musl-libc will fail with
    these errors:

    In file included from sysfs.c:31:0:
    tmon.h:47:8: error: unknown type name 'pthread_mutex_t'
    extern pthread_mutex_t input_lock;
    ^~~~~~~~~~~~~~~
    make[3]: *** [<builtin>: sysfs.o] Error 1
    make[3]: *** Waiting for unfinished jobs....
    In file included from tui.c:31:0:
    tmon.h:54:17: error: field 'tv' has incomplete type
    struct timeval tv;
    ^~
    make[3]: *** [<builtin>: tui.o] Error 1
    make[2]: *** [Makefile:83: tmon] Error 2

    Signed-off-by: Markus Mayer <mmayer@broadcom.com>
    Acked-by: Florian Fainelli <f.fainelli@gmail.com>
    Reviewed-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
    Acked-by: Alejandro González <alejandro.gonzalez.correo@gmail.com>
    Tested-by: Alejandro González <alejandro.gonzalez.correo@gmail.com>
    Fixes: 94f69966faf8 ("tools/thermal: Introduce tmon, a tool for thermal subsystem")
    Link: https://lore.kernel.org/r/20220718031040.44714-1-f.fainelli@gmail.com
    Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/thermal/tmon/tmon.h | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/tools/thermal/tmon/tmon.h b/tools/thermal/tmon/tmon.h
    index 9e3c49c547ac..7b090a6c95b6 100644
    --- a/tools/thermal/tmon/tmon.h
    +++ b/tools/thermal/tmon/tmon.h
    @@ -36,6 +36,9 @@
    #define NR_LINES_TZDATA 1
    #define TMON_LOG_FILE "/var/tmp/tmon.log"

    +#include <sys/time.h>
    +#include <pthread.h>
    +
    extern unsigned long ticktime;
    extern double time_elapsed;
    extern unsigned long target_temp_user;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 11:42    [W:4.094 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site