lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 314/365] drivers:md:fix a potential use-after-free bug
    Date
    From: Wentao_Liang <Wentao_Liang_g@163.com>

    [ Upstream commit 104212471b1c1817b311771d817fb692af983173 ]

    In line 2884, "raid5_release_stripe(sh);" drops the reference to sh and
    may cause sh to be released. However, sh is subsequently used in lines
    2886 "if (sh->batch_head && sh != sh->batch_head)". This may result in an
    use-after-free bug.

    It can be fixed by moving "raid5_release_stripe(sh);" to the bottom of
    the function.

    Signed-off-by: Wentao_Liang <Wentao_Liang_g@163.com>
    Signed-off-by: Song Liu <song@kernel.org>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/md/raid5.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
    index 45482cebacdb..1c1310d539f2 100644
    --- a/drivers/md/raid5.c
    +++ b/drivers/md/raid5.c
    @@ -2881,10 +2881,10 @@ static void raid5_end_write_request(struct bio *bi)
    if (!test_and_clear_bit(R5_DOUBLE_LOCKED, &sh->dev[i].flags))
    clear_bit(R5_LOCKED, &sh->dev[i].flags);
    set_bit(STRIPE_HANDLE, &sh->state);
    - raid5_release_stripe(sh);

    if (sh->batch_head && sh != sh->batch_head)
    raid5_release_stripe(sh->batch_head);
    + raid5_release_stripe(sh);
    }

    static void raid5_error(struct mddev *mddev, struct md_rdev *rdev)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 11:19    [W:4.100 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site