lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 16/20] dt-bindings: memory: snps: Detach Zynq DDRC controller support
On Tue, Aug 23, 2022 at 11:17:23AM +0300, Krzysztof Kozlowski wrote:
> On 22/08/2022 22:07, Serge Semin wrote:
> > The Zynq A05 DDRC controller has nothing in common with DW uMCTL2 DDRC:
> > the CSRs layout is absolutely different and it doesn't has IRQ unlike DW
> > uMCTL2 DDR controller of all versions (v1.x, v2.x and v3.x). Thus there is
> > no any reason to have these controllers described by the same bindings.
> > Thus let's split them up.
> >
> > While at it rename the original Synopsys uMCTL2 DT-schema file to a more
> > descriptive - snps,dw-umctl2-ddrc.yaml and add a more detailed title and
> > description of the device bindings.
>
> Filename should be based on compatible, so if renaming then
> snps,ddrc-3.80a.yaml or snps,ddrc.yaml... which leads to original
> filename anyway. Therefore nack for rename.
>
> BTW, if you perform renames, generate patches with proper -M/-C/-B
> arguments so this is detected.
>
>
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > ---> .../snps,dw-umctl2-ddrc.yaml | 51 +++++++++++++
>

> This is a mess. I did not get any cover letters, any other patches any
> description of relation between this and your other one.
>
> It seems you make independent and conflicting changes to the same file,
> so this has to be properly organized.

Don't hurry with the judgement. Have a better look at your DT-related
inbox.
Link: https://lore.kernel.org/linux-devicetree/20220822190730.27277-1-Sergey.Semin@baikalelectronics.ru/

-Sergey

>
> Send entire patchset with cover letter with description of all
> dependencies to all maintainers.
>
> This is unreviewable now, so a no.
>
> Best regards,
> Krzysztof

\
 
 \ /
  Last update: 2022-08-23 11:01    [W:0.086 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site