lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 162/365] fs/ntfs3: Dont clear upper bits accidentally in log_replay()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 926034353d3c67db1ffeab47dcb7f6bdac02a263 upstream.

    The "vcn" variable is a 64 bit. The "log->clst_per_page" variable is a
    u32. This means that the mask accidentally clears out the high 32 bits
    when it was only supposed to clear some low bits. Fix this by adding a
    cast to u64.

    Fixes: b46acd6a6a62 ("fs/ntfs3: Add NTFS journal")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Namjae Jeon <linkinjeon@kernel.org>
    Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ntfs3/fslog.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ntfs3/fslog.c
    +++ b/fs/ntfs3/fslog.c
    @@ -5057,7 +5057,7 @@ undo_action_next:
    goto add_allocated_vcns;

    vcn = le64_to_cpu(lrh->target_vcn);
    - vcn &= ~(log->clst_per_page - 1);
    + vcn &= ~(u64)(log->clst_per_page - 1);

    add_allocated_vcns:
    for (i = 0, vcn = le64_to_cpu(lrh->target_vcn),

    \
     
     \ /
      Last update: 2022-08-23 10:48    [W:2.125 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site