| From | Greg Kroah-Hartman <> | Subject | [PATCH 5.19 190/365] fs/ntfs3: uninitialized variable in ntfs_set_acl_ex() | Date | Tue, 23 Aug 2022 10:01:31 +0200 |
| |
From: Dan Carpenter <dan.carpenter@oracle.com>
commit d4073595d0c61463ec3a87411b19e2a90f76d3f8 upstream.
The goto out calls kfree(value) on an uninitialized pointer. Just return directly as the other error paths do.
Fixes: 460bbf2990b3 ("fs/ntfs3: Do not change mode if ntfs_set_ea failed") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- fs/ntfs3/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/ntfs3/xattr.c +++ b/fs/ntfs3/xattr.c @@ -563,7 +563,7 @@ static noinline int ntfs_set_acl_ex(stru err = posix_acl_update_mode(mnt_userns, inode, &mode, &acl); if (err) - goto out; + return err; } name = XATTR_NAME_POSIX_ACL_ACCESS; name_len = sizeof(XATTR_NAME_POSIX_ACL_ACCESS) - 1;
|