lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 094/101] tty: serial: Fix refcount leak bug in ucc_uart.c
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit d24d7bb2cd947676f9b71fb944d045e09b8b282f ]

    In soc_info(), of_find_node_by_type() will return a node pointer
    with refcount incremented. We should use of_node_put() when it is
    not used anymore.

    Acked-by: Timur Tabi <timur@kernel.org>
    Signed-off-by: Liang He <windhl@126.com>
    Link: https://lore.kernel.org/r/20220618060850.4058525-1-windhl@126.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/ucc_uart.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
    index 481eb2989a1e..ed1658b61e54 100644
    --- a/drivers/tty/serial/ucc_uart.c
    +++ b/drivers/tty/serial/ucc_uart.c
    @@ -1143,6 +1143,8 @@ static unsigned int soc_info(unsigned int *rev_h, unsigned int *rev_l)
    /* No compatible property, so try the name. */
    soc_string = np->name;

    + of_node_put(np);
    +
    /* Extract the SOC number from the "PowerPC," string */
    if ((sscanf(soc_string, "PowerPC,%u", &soc) != 1) || !soc)
    return 0;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 10:38    [W:2.225 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site