lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 142/365] vdpa_sim: use max_iotlb_entries as a limit in vhost_iotlb_init
    Date
    From: Stefano Garzarella <sgarzare@redhat.com>

    commit 67f8f10c0bd78c4a0f0e983e050ab90da015323b upstream.

    Commit bda324fd037a ("vdpasim: control virtqueue support") changed
    the allocation of iotlbs calling vhost_iotlb_init() for each address
    space, instead of vhost_iotlb_alloc().

    With this change we forgot to use the limit we had introduced with
    the `max_iotlb_entries` module parameter.

    Fixes: bda324fd037a ("vdpasim: control virtqueue support")
    Cc: gautam.dawar@xilinx.com
    Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
    Message-Id: <20220621151208.189959-1-sgarzare@redhat.com>
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Acked-by: Eugenio Pérez <eperezma@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
    index 0f2865899647..3e81532c01cb 100644
    --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
    +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
    @@ -33,7 +33,7 @@ MODULE_PARM_DESC(batch_mapping, "Batched mapping 1 -Enable; 0 - Disable");
    static int max_iotlb_entries = 2048;
    module_param(max_iotlb_entries, int, 0444);
    MODULE_PARM_DESC(max_iotlb_entries,
    - "Maximum number of iotlb entries. 0 means unlimited. (default: 2048)");
    + "Maximum number of iotlb entries for each address space. 0 means unlimited. (default: 2048)");

    #define VDPASIM_QUEUE_ALIGN PAGE_SIZE
    #define VDPASIM_QUEUE_MAX 256
    @@ -291,7 +291,7 @@ struct vdpasim *vdpasim_create(struct vdpasim_dev_attr *dev_attr)
    goto err_iommu;

    for (i = 0; i < vdpasim->dev_attr.nas; i++)
    - vhost_iotlb_init(&vdpasim->iommu[i], 0, 0);
    + vhost_iotlb_init(&vdpasim->iommu[i], max_iotlb_entries, 0);

    vdpasim->buffer = kvmalloc(dev_attr->buffer_size, GFP_KERNEL);
    if (!vdpasim->buffer)
    --
    2.37.2


    \
     
     \ /
      Last update: 2022-08-23 10:38    [W:4.147 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site