lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 092/365] dt-bindings: pinctrl: mt8192: Use generic bias instead of pull-*-adv
    Date
    From: Nícolas F. R. A. Prado <nfraprado@collabora.com>

    commit 353d2ef77f2be4c1b9b3c70f1637a9986f07b997 upstream.

    Commit cafe19db7751 ("pinctrl: mediatek: Backward compatible to previous
    Mediatek's bias-pull usage") allowed the bias-pull-up and bias-pull-down
    properties to be used for setting PUPD/R1/R0 type bias on mtk-paris
    based SoC's, which was previously only supported by the custom
    mediatek,pull-up-adv and mediatek,pull-down-adv properties.

    Since the bias-pull-{up,down} properties already have defines associated
    thus being more descriptive and is more universal on MediaTek platforms,
    and given that there are no mediatek,pull-{up,down}-adv users on mt8192
    yet, remove the custom adv properties in favor of the generic ones.

    Note that only mediatek,pull-up-adv was merged in the binding, but not
    its down counterpart.

    Fixes: edbacb36ea50 ("dt-bindings: pinctrl: mt8192: Add mediatek,pull-up-adv property")
    Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
    Reviewed-by: AngeloGioacchino Del Regno <angelogiocchino.delregno@collabora.com>
    Reviewed-by: Rob Herring <robh@kernel.org>
    Link: https://lore.kernel.org/r/20220525155714.1837360-3-nfraprado@collabora.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    .../bindings/pinctrl/pinctrl-mt8192.yaml | 29 ++++++++++---------
    1 file changed, 15 insertions(+), 14 deletions(-)

    diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml
    index 8ede8b750237..e39f5893bf16 100644
    --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml
    +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml
    @@ -83,20 +83,21 @@ patternProperties:
    drive-strength-microamp:
    enum: [125, 250, 500, 1000]

    - mediatek,pull-up-adv:
    - description: |
    - Pull up settings for 2 pull resistors, R0 and R1. User can
    - configure those special pins. Valid arguments are described as below:
    - 0: (R1, R0) = (0, 0) which means R1 disabled and R0 disabled.
    - 1: (R1, R0) = (0, 1) which means R1 disabled and R0 enabled.
    - 2: (R1, R0) = (1, 0) which means R1 enabled and R0 disabled.
    - 3: (R1, R0) = (1, 1) which means R1 enabled and R0 enabled.
    - $ref: /schemas/types.yaml#/definitions/uint32
    - enum: [0, 1, 2, 3]
    -
    - bias-pull-down: true
    -
    - bias-pull-up: true
    + bias-pull-down:
    + oneOf:
    + - type: boolean
    + description: normal pull down.
    + - enum: [100, 101, 102, 103]
    + description: PUPD/R1/R0 pull down type. See MTK_PUPD_SET_R1R0_
    + defines in dt-bindings/pinctrl/mt65xx.h.
    +
    + bias-pull-up:
    + oneOf:
    + - type: boolean
    + description: normal pull up.
    + - enum: [100, 101, 102, 103]
    + description: PUPD/R1/R0 pull up type. See MTK_PUPD_SET_R1R0_
    + defines in dt-bindings/pinctrl/mt65xx.h.

    bias-disable: true

    --
    2.37.2


    \
     
     \ /
      Last update: 2022-08-23 10:25    [W:4.065 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site