lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 4/4] Revert "iommu/of: Delete usage of driver_deferred_probe_check_state()"
    On Fri, Aug 19, 2022 at 03:16:14PM -0700, Saravana Kannan wrote:
    > This reverts commit b09796d528bbf06e3e10a4a8f78038719da7ebc6.
    >
    > An issue was reported[1] on the original commit. I'll need to address that
    > before I can delete the use of driver_deferred_probe_check_state(). So,
    > bring it back for now.
    >
    > [1] - https://lore.kernel.org/lkml/4799738.LvFx2qVVIh@steina-w/

    https://lore.kernel.org/lkml/Yv+dpeIPvde7oDHi@myrica/

    >
    > Fixes: b09796d528bb ("iommu/of: Delete usage of driver_deferred_probe_check_state()")
    > Reported-by: Jean-Philippe Brucker <jpb@kernel.org>
    > Signed-off-by: Saravana Kannan <saravanak@google.com>

    Tested-by: Jean-Philippe Brucker <jpb@kernel.org>

    > ---
    > drivers/iommu/of_iommu.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
    > index 41f4eb005219..5696314ae69e 100644
    > --- a/drivers/iommu/of_iommu.c
    > +++ b/drivers/iommu/of_iommu.c
    > @@ -40,7 +40,7 @@ static int of_iommu_xlate(struct device *dev,
    > * a proper probe-ordering dependency mechanism in future.
    > */
    > if (!ops)
    > - return -ENODEV;
    > + return driver_deferred_probe_check_state(dev);
    >
    > if (!try_module_get(ops->owner))
    > return -ENODEV;
    > --
    > 2.37.1.595.g718a3a8f04-goog
    >

    \
     
     \ /
      Last update: 2022-08-23 10:25    [W:4.359 / U:0.912 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site