lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 078/365] virtio: VIRTIO_HARDEN_NOTIFICATION is broken
    Date
    From: Michael S. Tsirkin <mst@redhat.com>

    commit ebe797f25f68f28581f46a9cb9c1997ac15c39a0 upstream.

    This option doesn't really work and breaks too many drivers.
    Not yet sure what's the right thing to do, for now
    let's make sure randconfig isn't broken by this.

    Fixes: c346dae4f3fb ("virtio: disable notification hardening by default")
    Cc: "Jason Wang" <jasowang@redhat.com>
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Acked-by: Jason Wang <jasowang@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/virtio/Kconfig | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/virtio/Kconfig
    +++ b/drivers/virtio/Kconfig
    @@ -35,11 +35,12 @@ if VIRTIO_MENU

    config VIRTIO_HARDEN_NOTIFICATION
    bool "Harden virtio notification"
    + depends on BROKEN
    help
    Enable this to harden the device notifications and suppress
    those that happen at a time where notifications are illegal.

    - Experimental: Note that several drivers still have bugs that
    + Experimental: Note that several drivers still have issues that
    may cause crashes or hangs when correct handling of
    notifications is enforced; depending on the subset of
    drivers and devices you use, this may or may not work.

    \
     
     \ /
      Last update: 2022-08-23 10:20    [W:4.022 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site