Messages in this thread | | | Date | Wed, 24 Aug 2022 12:54:14 +0900 | From | Hyeonggon Yoo <> | Subject | Re: [PATCH v4 13/17] mm/sl[au]b: cleanup kmem_cache_alloc[_node]_trace() |
| |
On Tue, Aug 23, 2022 at 05:04:36PM +0200, Vlastimil Babka wrote: > On 8/17/22 12:18, Hyeonggon Yoo wrote: > > This patch does: > > I've removed this line locally and re-idented the rest.
Ah, thanks. looks better.
> > - Despite its name, kmem_cache_alloc[_node]_trace() is hook for > > inlined kmalloc. So rename it to kmalloc[_node]_trace(). > > > > - Move its implementation to slab_common.c by using > > __kmem_cache_alloc_node(), but keep CONFIG_TRACING=n varients to > > save a function call when CONFIG_TRACING=n. > > > > - Use __assume_kmalloc_alignment for kmalloc[_node]_trace > > instead of __assume_slab_alignement. Generally kmalloc has > > larger alignment requirements. > > > > Suggested-by: Vlastimil Babka <vbabka@suse.cz> > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Thanks!
-- Thanks, Hyeonggon
| |