lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] xfs: remove "%Lu" which doesn't meet C standard
From
Yes, I'm pleasure send more similar patches if they were a bit helpful 
for xfs.

Besides, I'm just a rookie in XFS, and have read about your edition of

<XFS Algorithms & Data Structures>.

Just let you know, it's a good job.


Best Regards,

Zeng Heng


在 2022/8/23 22:27, Darrick J. Wong 写道:
> On Tue, Aug 23, 2022 at 09:55:17AM +0800, Zeng Heng wrote:
>> The "%Lu" specifier, which represents long long unsigned,
>> doesn't meet C language standard, and even more,
>> it makes people easily mistake with "%lu", which represent
>> long unsigned. So replace "%Lu" with "llu".
>>
>> Signed-off-by: Zeng Heng <zengheng4@huawei.com>
> Yesss finally fixing this
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>
> --D
>
>> ---
>> fs/xfs/xfs_inode.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
>> index 28493c8e9bb2..b3eeeae3afe1 100644
>> --- a/fs/xfs/xfs_inode.c
>> +++ b/fs/xfs/xfs_inode.c
>> @@ -3119,7 +3119,7 @@ xfs_iflush(
>> if (XFS_TEST_ERROR(dip->di_magic != cpu_to_be16(XFS_DINODE_MAGIC),
>> mp, XFS_ERRTAG_IFLUSH_1)) {
>> xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
>> - "%s: Bad inode %Lu magic number 0x%x, ptr "PTR_FMT,
>> + "%s: Bad inode %llu magic number 0x%x, ptr "PTR_FMT,
>> __func__, ip->i_ino, be16_to_cpu(dip->di_magic), dip);
>> goto flush_out;
>> }
>> @@ -3129,7 +3129,7 @@ xfs_iflush(
>> ip->i_df.if_format != XFS_DINODE_FMT_BTREE,
>> mp, XFS_ERRTAG_IFLUSH_3)) {
>> xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
>> - "%s: Bad regular inode %Lu, ptr "PTR_FMT,
>> + "%s: Bad regular inode %llu, ptr "PTR_FMT,
>> __func__, ip->i_ino, ip);
>> goto flush_out;
>> }
>> @@ -3140,7 +3140,7 @@ xfs_iflush(
>> ip->i_df.if_format != XFS_DINODE_FMT_LOCAL,
>> mp, XFS_ERRTAG_IFLUSH_4)) {
>> xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
>> - "%s: Bad directory inode %Lu, ptr "PTR_FMT,
>> + "%s: Bad directory inode %llu, ptr "PTR_FMT,
>> __func__, ip->i_ino, ip);
>> goto flush_out;
>> }
>> @@ -3158,7 +3158,7 @@ xfs_iflush(
>> if (XFS_TEST_ERROR(ip->i_forkoff > mp->m_sb.sb_inodesize,
>> mp, XFS_ERRTAG_IFLUSH_6)) {
>> xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
>> - "%s: bad inode %Lu, forkoff 0x%x, ptr "PTR_FMT,
>> + "%s: bad inode %llu, forkoff 0x%x, ptr "PTR_FMT,
>> __func__, ip->i_ino, ip->i_forkoff, ip);
>> goto flush_out;
>> }
>> --
>> 2.25.1
>>

\
 
 \ /
  Last update: 2022-08-24 03:55    [W:0.042 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site