lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [for-linus][PATCH 01/10] tracing: Suppress sparse warnings triggered by is_signed_type()
    On Tue, Aug 23, 2022 at 3:05 PM Bart Van Assche <bvanassche@acm.org> wrote:
    >
    > Thank you Rasmus for having shared this information. Since sparse will
    > have to be modified anyway, how about extending it such that the bitwise
    > attribute can be removed from a type, e.g. via a new no_bitwise
    > attribute?

    I think it's actually easier to just make sparse happy.

    Can you try the sparse version at

    git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/sparse.git

    which I just set up temporarily with some patches of mine. It also
    makes that '__cond_acquires' thing work that refcount_dec_and_lock()
    uses.

    It does require that kernel change to make

    #define is_signed_type(type) (((type)(-1)) <= (type)0)

    in both places, since only "no bits set" and "all bits set" are
    special values for bitwise types.

    Those patches of mine are fairly hacky, and I think Luc would probably
    do it differently, but apart from the very last one, they aren't
    actively disgusting.

    Linus

    \
     
     \ /
      Last update: 2022-08-24 01:19    [W:4.404 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site