lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net] net: phylink: allow RGMII/RTBI in-band status
On Fri, 19 Aug 2022 17:26:06 +0800 Qingfang DENG wrote:
> As per RGMII specification v2.0, section 3.4.1, RGMII/RTBI has an
> optional in-band status feature where the PHY's link status, speed and
> duplex mode can be passed to the MAC.
> Allow RGMII/RTBI to use in-band status.
>
> Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> Signed-off-by: Qingfang DENG <dqfext@gmail.com>

Russell, PHY folks, any judgment on this one?

Qingfang is there a platform which require RGMII to be supported
in upstream LTS branches? If there isn't you should re-target
the patch at net-next and drop the Fixes tag. Not implementing
the entire spec is not considered a bug. Please clarify this
in the commit message.

> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 9bd69328dc4d..57186d322835 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -632,6 +632,11 @@ static int phylink_parse_mode(struct phylink *pl, struct fwnode_handle *fwnode)
> switch (pl->link_config.interface) {
> case PHY_INTERFACE_MODE_SGMII:
> case PHY_INTERFACE_MODE_QSGMII:
> + case PHY_INTERFACE_MODE_RGMII:
> + case PHY_INTERFACE_MODE_RGMII_ID:
> + case PHY_INTERFACE_MODE_RGMII_RXID:
> + case PHY_INTERFACE_MODE_RGMII_TXID:
> + case PHY_INTERFACE_MODE_RTBI:
> phylink_set(pl->supported, 10baseT_Half);
> phylink_set(pl->supported, 10baseT_Full);
> phylink_set(pl->supported, 100baseT_Half);

\
 
 \ /
  Last update: 2022-08-24 00:28    [W:0.040 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site