lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 005/101] net: sungem_phy: Add of_node_put() for reference returned by of_get_parent()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit ebbbe23fdf6070e31509638df3321688358cc211 ]

    In bcm5421_init(), we should call of_node_put() for the reference
    returned by of_get_parent() which has increased the refcount.

    Fixes: 3c326fe9cb7a ("[PATCH] ppc64: Add new PHY to sungem")
    Signed-off-by: Liang He <windhl@126.com>
    Link: https://lore.kernel.org/r/20220720131003.1287426-1-windhl@126.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/sungem_phy.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
    index 92578d72e4ee..c5efdde21c2e 100644
    --- a/drivers/net/sungem_phy.c
    +++ b/drivers/net/sungem_phy.c
    @@ -453,6 +453,7 @@ static int bcm5421_init(struct mii_phy* phy)
    int can_low_power = 1;
    if (np == NULL || of_get_property(np, "no-autolowpower", NULL))
    can_low_power = 0;
    + of_node_put(np);
    if (can_low_power) {
    /* Enable automatic low-power */
    sungem_phy_write(phy, 0x1c, 0x9002);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 10:14    [W:3.315 / U:2.772 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site