Messages in this thread | | | Date | Tue, 23 Aug 2022 21:19:52 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH v4.4] net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy |
| |
On Tue, Aug 23, 2022 at 08:53:54PM +0200, Andrew Lunn wrote: > > > The user could of changed the pause settings, which are going to be > > > ignored here. Also, you should not assume the MAC can actually do > > > asymmetric pause, not all can. phydev->advertising will be set to only > > > include what the MAC can actually do. > > > Interesting. Just to confirm - regardless of the two-sided design.. > > -edness.. IIUC my question has merit and we need v5? > > Yes, phydev->advertising should be take into account.
It's worth pointing out that there is a helper for this - linkmode_adv_to_mii_adv_x().
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |