Messages in this thread | | | Date | Wed, 24 Aug 2022 03:48:55 +0800 | From | kernel test robot <> | Subject | [leon-rdma:xfrm-next 4/34] net/xfrm/xfrm_device.c:383:56: warning: suggest parentheses around '&&' within '||' |
| |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git xfrm-next head: a3d3cb4010b4294c2c6a60d398dd417f335982f3 commit: d7b5afa45594beb1a60cba94c0e9e2b645c6a881 [4/34] xfrm: add TX datapath support for IPsec full offload mode config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220824/202208240319.plmxMsEF-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/commit/?id=d7b5afa45594beb1a60cba94c0e9e2b645c6a881 git remote add leon-rdma https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git git fetch --no-tags leon-rdma xfrm-next git checkout d7b5afa45594beb1a60cba94c0e9e2b645c6a881 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash net/xfrm/
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
net/xfrm/xfrm_device.c: In function 'xfrm_dev_offload_ok': >> net/xfrm/xfrm_device.c:383:56: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 383 | (!dev || (dev == xfrm_dst_path(dst)->dev)) && !xdst->child->xfrm) { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
vim +383 net/xfrm/xfrm_device.c
371 372 bool xfrm_dev_offload_ok(struct sk_buff *skb, struct xfrm_state *x) 373 { 374 int mtu; 375 struct dst_entry *dst = skb_dst(skb); 376 struct xfrm_dst *xdst = (struct xfrm_dst *)dst; 377 struct net_device *dev = x->xso.dev; 378 379 if (!x->type_offload || x->encap) 380 return false; 381 382 if (x->xso.type == XFRM_DEV_OFFLOAD_FULL || > 383 (!dev || (dev == xfrm_dst_path(dst)->dev)) && !xdst->child->xfrm) { 384 mtu = xfrm_state_mtu(x, xdst->child_mtu_cached); 385 if (skb->len <= mtu) 386 goto ok; 387 388 if (skb_is_gso(skb) && skb_gso_validate_network_len(skb, mtu)) 389 goto ok; 390 } 391 392 return false; 393 394 ok: 395 if (dev && dev->xfrmdev_ops && dev->xfrmdev_ops->xdo_dev_offload_ok) 396 return x->xso.dev->xfrmdev_ops->xdo_dev_offload_ok(skb, x); 397 398 return true; 399 } 400 EXPORT_SYMBOL_GPL(xfrm_dev_offload_ok); 401
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |