Messages in this thread | | | Date | Tue, 23 Aug 2022 08:29:47 -1000 | From | Tejun Heo <> | Subject | Re: [PATCH 3/4] blk-throttle: cleanup tg_update_disptime() |
| |
On Tue, Aug 23, 2022 at 09:38:09AM +0800, Yu Kuai wrote: > From: Yu Kuai <yukuai3@huawei.com> > > tg_update_disptime() only need to adjust postion for 'tg' in > 'parent_sq', there is no need to call throtl_enqueue/dequeue_tg(), > since they will set/clear flag THROTL_TG_PENDING and increase/decrease > nr_pending, which is useless. By the way, clear the flag/decrease > nr_pending while there are still throttled bios is not good for debugging. > > There are no functional changes. > > Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |