Messages in this thread | | | From | Prashant Malani <> | Date | Tue, 23 Aug 2022 10:52:39 -0700 | Subject | Re: [PATCH 3/4] platform/chrome: cros_ec_typec: Stash port driver info |
| |
Thanks for the reviews folks.
On Tue, Aug 23, 2022 at 1:17 AM Heikki Krogerus <heikki.krogerus@linux.intel.com> wrote: > > On Tue, Aug 23, 2022 at 04:43:41AM +0000, Tzung-Bi Shih wrote: > > On Fri, Aug 19, 2022 at 07:08:04PM +0000, Prashant Malani wrote: > > > Stash port number and a pointer to the driver-specific struct in the > > > local Type-C port struct. > > > > > > These can be useful to the port driver to figure out how to communicate > > > with the ChromeOS EC when an altmode driver related callback is invoked > > > from the Type-C class code. > > > > The patch looks good to me. But I would suggest to send it in later series > > that uses the driver-specific struct (e.g. in altmode driver related callbacks) > > to make the usage clear. > > I agree.
Ok. I will resend this along with the alt mode series.
BR,
-Prashant
| |