lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 3/4] platform/chrome: cros_ec_typec: Stash port driver info
    Thanks for the reviews folks.

    On Tue, Aug 23, 2022 at 1:17 AM Heikki Krogerus
    <heikki.krogerus@linux.intel.com> wrote:
    >
    > On Tue, Aug 23, 2022 at 04:43:41AM +0000, Tzung-Bi Shih wrote:
    > > On Fri, Aug 19, 2022 at 07:08:04PM +0000, Prashant Malani wrote:
    > > > Stash port number and a pointer to the driver-specific struct in the
    > > > local Type-C port struct.
    > > >
    > > > These can be useful to the port driver to figure out how to communicate
    > > > with the ChromeOS EC when an altmode driver related callback is invoked
    > > > from the Type-C class code.
    > >
    > > The patch looks good to me. But I would suggest to send it in later series
    > > that uses the driver-specific struct (e.g. in altmode driver related callbacks)
    > > to make the usage clear.
    >
    > I agree.

    Ok. I will resend this along with the alt mode series.

    BR,

    -Prashant

    \
     
     \ /
      Last update: 2022-08-23 21:17    [W:3.098 / U:0.680 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site