lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/4] platform/chrome: cros_ec_typec: Correct alt mode index
    Hi Heikki,

    Thanks for the review.

    On Tue, Aug 23, 2022 at 1:14 AM Heikki Krogerus
    <heikki.krogerus@linux.intel.com> wrote:
    >
    > Hi,
    >
    > On Fri, Aug 19, 2022 at 07:08:03PM +0000, Prashant Malani wrote:
    > > Alt mode indices used by USB PD (Power Delivery) start with 1, not 0.
    > >
    > > Update the alt mdoe registration code to factor this in to the alt mode
    > > descriptor.
    > >
    > > Fixes: de0f49487db3 ("platform/chrome: cros_ec_typec: Register partner altmodes")
    > > Signed-off-by: Prashant Malani <pmalani@chromium.org>
    >
    > Shouldn't this be applied also to the stable kernels?

    We're not planning on backporting alt mode driver stuff to older
    kernels, so probably not necessary
    (aside from where it gets auto-magically picked).
    Userspace currently doesn't use the mode index for anything.

    Please LMK if you still feel it should go to stable.

    >
    > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    >

    \
     
     \ /
      Last update: 2022-08-23 20:53    [W:3.875 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site