lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2] dmaengine: idxd: avoid deadlock in process_misc_interrupts()
    From

    On 8/23/2022 9:37 AM, Jerry Snitselaar wrote:
    > idxd_device_clear_state() now grabs the idxd->dev_lock
    > itself, so don't grab the lock prior to calling it.
    >
    > This was seen in testing after dmar fault occurred on system,
    > resulting in lockup stack traces.
    >
    > Cc: Fenghua Yu <fenghua.yu@intel.com>
    > Cc: Dave Jiang <dave.jiang@intel.com>
    > Cc: Vinod Koul <vkoul@kernel.org>
    > Cc: dmaengine@vger.kernel.org
    > Fixes: cf4ac3fef338 ("dmaengine: idxd: fix lockdep warning on device driver removal")
    > Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>

    Thanks Jerry!

    Reviewed-by: Dave Jiang <dave.jiang@intel.com>

    > ---
    > v2: add Fixes tag, and add subsystem to summary
    >
    > drivers/dma/idxd/irq.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
    > index 743ead5ebc57..5b9921475be6 100644
    > --- a/drivers/dma/idxd/irq.c
    > +++ b/drivers/dma/idxd/irq.c
    > @@ -324,13 +324,11 @@ static int process_misc_interrupts(struct idxd_device *idxd, u32 cause)
    > idxd->state = IDXD_DEV_HALTED;
    > idxd_wqs_quiesce(idxd);
    > idxd_wqs_unmap_portal(idxd);
    > - spin_lock(&idxd->dev_lock);
    > idxd_device_clear_state(idxd);
    > dev_err(&idxd->pdev->dev,
    > "idxd halted, need %s.\n",
    > gensts.reset_type == IDXD_DEVICE_RESET_FLR ?
    > "FLR" : "system reset");
    > - spin_unlock(&idxd->dev_lock);
    > return -ENXIO;
    > }
    > }

    \
     
     \ /
      Last update: 2022-08-23 20:28    [W:2.114 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site