lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drm/exynos: fix repeated words in comments
From
On 2022-08-23 13:21, Jilin Yuan wrote:
> Delete the redundant word 'next'.

From the context, I'm not sure it is redundant - as far as I can tell
this comment seems to be describing a sequence of 3 commands, where
"current" is the first, "next" is the second, and "next next" implies
the third. The whole comment could certainly be reworded more clearly,
but as it stands I suspect a replacement like s/next next/next+1/ is
more likely to be correct.

Robin.

> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> index 471fd6c8135f..4f9edca66632 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -1195,7 +1195,7 @@ int exynos_g2d_set_cmdlist_ioctl(struct drm_device *drm_dev, void *data,
> * If don't clear SFR registers, the cmdlist is affected by register
> * values of previous cmdlist. G2D hw executes SFR clear command and
> * a next command at the same time then the next command is ignored and
> - * is executed rightly from next next command, so needs a dummy command
> + * is executed rightly from next command, so needs a dummy command
> * to next command of SFR clear command.
> */
> cmdlist->data[cmdlist->last++] = G2D_SOFT_RESET;

\
 
 \ /
  Last update: 2022-08-23 19:13    [W:2.434 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site