lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH linux-next v2] mm/slub: Remove the unneeded result variable
From
On 8/22/22 03:38, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value from attribute->store(s, buf, len) and
> attribute->show(s, buf) directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Thanks, added to slab.git for-6.1/trivial

> ---
> v1 -> v2
> Add the whitespace between subsystem and summary in subject line.
> mm/slub.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 6953c3367bc2..7bea010a20ff 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -5852,7 +5852,6 @@ static ssize_t slab_attr_show(struct kobject *kobj,
> {
> struct slab_attribute *attribute;
> struct kmem_cache *s;
> - int err;
>
> attribute = to_slab_attr(attr);
> s = to_slab(kobj);
> @@ -5860,9 +5859,7 @@ static ssize_t slab_attr_show(struct kobject *kobj,
> if (!attribute->show)
> return -EIO;
>
> - err = attribute->show(s, buf);
> -
> - return err;
> + return attribute->show(s, buf);
> }
>
> static ssize_t slab_attr_store(struct kobject *kobj,
> @@ -5871,7 +5868,6 @@ static ssize_t slab_attr_store(struct kobject *kobj,
> {
> struct slab_attribute *attribute;
> struct kmem_cache *s;
> - int err;
>
> attribute = to_slab_attr(attr);
> s = to_slab(kobj);
> @@ -5879,8 +5875,7 @@ static ssize_t slab_attr_store(struct kobject *kobj,
> if (!attribute->store)
> return -EIO;
>
> - err = attribute->store(s, buf, len);
> - return err;
> + return attribute->store(s, buf, len);
> }
>
> static void kmem_cache_release(struct kobject *k)

\
 
 \ /
  Last update: 2022-08-23 19:07    [W:0.050 / U:1.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site